github/hexo-theme-next
1
0
Fork 0
mirror of https://github.com/next-theme/hexo-theme-next.git synced 2026-01-19 18:42:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

Better use of parseInt and Number

Browse Source
This commit is contained in:
Mimi 2024-05-09 23:21:24 +08:00
parent 07acb27cc9
commit 17259c0018
2 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
source/js/bookmark.js
View File

@ -9,7 +9,7 @@ document.addEventListener('DOMContentLoaded', () => {
const scrollToMark = () => { const scrollToMark = () => {
let top = localStorage.getItem('bookmark' + location.pathname); let top = localStorage.getItem('bookmark' + location.pathname);
top = parseInt(top, 10); top = Number(top);
// If the page opens with a specific hash, just jump out // If the page opens with a specific hash, just jump out
if (!isNaN(top) && location.hash === '') { if (!isNaN(top) && location.hash === '') {
// Auto scroll to the position // Auto scroll to the position

12
source/js/utils.js
View File

@ -60,7 +60,7 @@ NexT.utils = {
}); });
}); });
} }
const height = parseInt(window.getComputedStyle(element).height.replace('px', ''), 10); const height = parseInt(window.getComputedStyle(element).height, 10);
// Skip pre > .mermaid for folding but keep the copy button // Skip pre > .mermaid for folding but keep the copy button
// Note that it only works before mermaid.js loaded (race condition) // Note that it only works before mermaid.js loaded (race condition)
const needFold = CONFIG.fold.enable && (height > CONFIG.fold.height) && !element.querySelector('.mermaid'); const needFold = CONFIG.fold.enable && (height > CONFIG.fold.height) && !element.querySelector('.mermaid');
@ -221,9 +221,9 @@ NexT.utils = {
// Comment system selection tab does not contain .active class. // Comment system selection tab does not contain .active class.
const activeTab = tabContent.querySelector('.active') || tabContent.firstElementChild; const activeTab = tabContent.querySelector('.active') || tabContent.firstElementChild;
// Hight might be `auto`. // Hight might be `auto`.
const prevHeight = parseInt(window.getComputedStyle(activeTab).height.replace('px', ''), 10) || 0; const prevHeight = parseInt(window.getComputedStyle(activeTab).height, 10) || 0;
const paddingTop = parseInt(window.getComputedStyle(activeTab).paddingTop.replace('px', ''), 10); const paddingTop = parseInt(window.getComputedStyle(activeTab).paddingTop, 10);
const marginBottom = parseInt(window.getComputedStyle(activeTab.firstElementChild).marginBottom.replace('px', ''), 10); const marginBottom = parseInt(window.getComputedStyle(activeTab.firstElementChild).marginBottom, 10);
tabContent.style.height = prevHeight + paddingTop + marginBottom + 'px'; tabContent.style.height = prevHeight + paddingTop + marginBottom + 'px';
// Add & Remove active class on `nav-tabs` & `tab-content`. // Add & Remove active class on `nav-tabs` & `tab-content`.
[...nav.children].forEach(target => { [...nav.children].forEach(target => {
@ -240,7 +240,7 @@ NexT.utils = {
})); }));
// Get the height of `tab-pane` which is activated now. // Get the height of `tab-pane` which is activated now.
const hasScrollBar = document.body.scrollHeight > (window.innerHeight || document.documentElement.clientHeight); const hasScrollBar = document.body.scrollHeight > (window.innerHeight || document.documentElement.clientHeight);
const currHeight = parseInt(window.getComputedStyle(tabContent.querySelector('.active')).height.replace('px', ''), 10); const currHeight = parseInt(window.getComputedStyle(tabContent.querySelector('.active')).height, 10);
// Reset the height of `tab-content` and see the animation. // Reset the height of `tab-content` and see the animation.
tabContent.style.height = currHeight + paddingTop + marginBottom + 'px'; tabContent.style.height = currHeight + paddingTop + marginBottom + 'px';
// Change the height of `tab-content` may cause scrollbar show / disappear, which may result in the change of the `tab-pane`'s height // Change the height of `tab-content` may cause scrollbar show / disappear, which may result in the change of the `tab-pane`'s height
@ -248,7 +248,7 @@ NexT.utils = {
if ((document.body.scrollHeight > (window.innerHeight || document.documentElement.clientHeight)) !== hasScrollBar) { if ((document.body.scrollHeight > (window.innerHeight || document.documentElement.clientHeight)) !== hasScrollBar) {
tabContent.style.transition = 'height 0.3s linear'; tabContent.style.transition = 'height 0.3s linear';
// After the animation, we need reset the height of `tab-content` again. // After the animation, we need reset the height of `tab-content` again.
const currHeightAfterScrollBarChange = parseInt(window.getComputedStyle(tabContent.querySelector('.active')).height.replace('px', ''), 10); const currHeightAfterScrollBarChange = parseInt(window.getComputedStyle(tabContent.querySelector('.active')).height, 10);
tabContent.style.height = currHeightAfterScrollBarChange + paddingTop + marginBottom + 'px'; tabContent.style.height = currHeightAfterScrollBarChange + paddingTop + marginBottom + 'px';
} }
// Remove all the inline styles, and let the height be adaptive again. // Remove all the inline styles, and let the height be adaptive again.