From 0e51e29a12bbd1a386ad63c6710a7c79b642c8af Mon Sep 17 00:00:00 2001
From: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Date: Wed, 31 Mar 2021 15:46:45 -0400
Subject: [PATCH] Add aria-label for buttons and selects (#234)

---
 languages/en.yml               | 2 ++
 languages/zh-CN.yml            | 2 ++
 layout/_macro/sidebar.njk      | 2 +-
 layout/_partials/languages.njk | 2 +-
 layout/_partials/widgets.njk   | 2 +-
 5 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/languages/en.yml b/languages/en.yml
index 5484341..59515bc 100644
--- a/languages/en.yml
+++ b/languages/en.yml
@@ -102,6 +102,8 @@ accessibility:
   nav_toggle: Toggle navigation bar
   prev_page: Previous page
   next_page: Next page
+  back_to_top: Back to top
+  select_lang: Select language
 
 symbols_count_time:
   count: Symbols count in article
diff --git a/languages/zh-CN.yml b/languages/zh-CN.yml
index 5e32fb4..51838dc 100644
--- a/languages/zh-CN.yml
+++ b/languages/zh-CN.yml
@@ -87,6 +87,8 @@ accessibility:
   nav_toggle: 切换导航栏
   prev_page: 上一页
   next_page: 下一页
+  back_to_top: 返回顶部
+  select_lang: 选择语言
 symbols_count_time:
   count: 本文字数
   count_total: 站点总字数
diff --git a/layout/_macro/sidebar.njk b/layout/_macro/sidebar.njk
index 119b1e8..bae7322 100644
--- a/layout/_macro/sidebar.njk
+++ b/layout/_macro/sidebar.njk
@@ -39,7 +39,7 @@
       </div>
 
       {%- if theme.back2top.enable and theme.back2top.sidebar %}
-        <div class="back-to-top animated" role="button">
+        <div class="back-to-top animated" role="button" aria-label="{{ __('accessibility.back_to_top') }}">
           <i class="fa fa-arrow-up"></i>
           <span>0%</span>
         </div>
diff --git a/layout/_partials/languages.njk b/layout/_partials/languages.njk
index cbe5443..a23f07f 100644
--- a/layout/_partials/languages.njk
+++ b/layout/_partials/languages.njk
@@ -5,7 +5,7 @@
       <span>{{ language_name(page.lang) }}</span>
       <i class="fa fa-angle-up" aria-hidden="true"></i>
     </label>
-    <select class="lang-select" data-canonical="">
+    <select class="lang-select" data-canonical="" aria-label="{{ __('accessibility.select_lang') }}">
       {% for language in languages %}
         <option value="{{ language }}" data-href="{{ i18n_path(language) }}" selected="">
           {{ language_name(language) }}
diff --git a/layout/_partials/widgets.njk b/layout/_partials/widgets.njk
index 38a70ed..996a931 100644
--- a/layout/_partials/widgets.njk
+++ b/layout/_partials/widgets.njk
@@ -1,5 +1,5 @@
 {%- if theme.back2top.enable and not theme.back2top.sidebar %}
-  <div class="back-to-top" role="button">
+  <div class="back-to-top" role="button" aria-label="{{ __('accessibility.back_to_top') }}">
     <i class="fa fa-arrow-up"></i>
     <span>0%</span>
   </div>